What does 'let x = x' do in Rust?
I saw this code in the wild:
fields.sort_by_key(|&(_, ref field)| field.tags().into_iter().min().unwrap());
let fields = fields;
What does the let fields = fields; line do? Why is it there?
rust
add a comment |
I saw this code in the wild:
fields.sort_by_key(|&(_, ref field)| field.tags().into_iter().min().unwrap());
let fields = fields;
What does the let fields = fields; line do? Why is it there?
rust
add a comment |
I saw this code in the wild:
fields.sort_by_key(|&(_, ref field)| field.tags().into_iter().min().unwrap());
let fields = fields;
What does the let fields = fields; line do? Why is it there?
rust
I saw this code in the wild:
fields.sort_by_key(|&(_, ref field)| field.tags().into_iter().min().unwrap());
let fields = fields;
What does the let fields = fields; line do? Why is it there?
rust
rust
edited Feb 9 at 20:19
Shepmaster
161k16330474
161k16330474
asked Feb 8 at 15:13
timtheliontimthelion
1,0781321
1,0781321
add a comment |
add a comment |
2 Answers
2
active
oldest
votes
It makes fields immutable again.
fields was previously defined as mutable (let mut fields = …;), to be used with sort_by_key which sorts in-place and requires the target to be mutable. The author has chosen here to explicitly prevent further mutability.
"Downgrading" a mutable binding to immutable is quite common in Rust.
Another common way to do this is to use a block expression:
let fields = {
let mut fields = …;
fields.sort_by_key(…);
fields
};
34
Or "upgrading", depending upon your perspective.
– Synesso
Feb 9 at 3:06
6
IMO your another way to write that is the way to go: the mutable variable is scoped the time we need to use it, and then it is moved. It is better semantically.
– French Boiethios
Feb 13 at 8:48
@DarthBoiethios Does one or the other changes anything to compiled code? Like adding an additional, useless instruction? Or enabling more aggressive optimisations by the compiler based on immutability assumptions?
– iago-lito
Feb 27 at 19:22
1
@iago-lito Honestly, I'm not sure, but my uneducated guess is that is does not change anything.
– French Boiethios
Feb 27 at 19:47
1
@iago-lito Right now it actually does! However this is considered a bug and is likely to be fixed at some point.
– mcarton
Feb 27 at 20:13
|
show 1 more comment
The statement let var = var; makes var immutable and bound to its current value. fields was declared as mut earlier.
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54595345%2fwhat-does-let-x-x-do-in-rust%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
2 Answers
2
active
oldest
votes
2 Answers
2
active
oldest
votes
active
oldest
votes
active
oldest
votes
It makes fields immutable again.
fields was previously defined as mutable (let mut fields = …;), to be used with sort_by_key which sorts in-place and requires the target to be mutable. The author has chosen here to explicitly prevent further mutability.
"Downgrading" a mutable binding to immutable is quite common in Rust.
Another common way to do this is to use a block expression:
let fields = {
let mut fields = …;
fields.sort_by_key(…);
fields
};
34
Or "upgrading", depending upon your perspective.
– Synesso
Feb 9 at 3:06
6
IMO your another way to write that is the way to go: the mutable variable is scoped the time we need to use it, and then it is moved. It is better semantically.
– French Boiethios
Feb 13 at 8:48
@DarthBoiethios Does one or the other changes anything to compiled code? Like adding an additional, useless instruction? Or enabling more aggressive optimisations by the compiler based on immutability assumptions?
– iago-lito
Feb 27 at 19:22
1
@iago-lito Honestly, I'm not sure, but my uneducated guess is that is does not change anything.
– French Boiethios
Feb 27 at 19:47
1
@iago-lito Right now it actually does! However this is considered a bug and is likely to be fixed at some point.
– mcarton
Feb 27 at 20:13
|
show 1 more comment
It makes fields immutable again.
fields was previously defined as mutable (let mut fields = …;), to be used with sort_by_key which sorts in-place and requires the target to be mutable. The author has chosen here to explicitly prevent further mutability.
"Downgrading" a mutable binding to immutable is quite common in Rust.
Another common way to do this is to use a block expression:
let fields = {
let mut fields = …;
fields.sort_by_key(…);
fields
};
34
Or "upgrading", depending upon your perspective.
– Synesso
Feb 9 at 3:06
6
IMO your another way to write that is the way to go: the mutable variable is scoped the time we need to use it, and then it is moved. It is better semantically.
– French Boiethios
Feb 13 at 8:48
@DarthBoiethios Does one or the other changes anything to compiled code? Like adding an additional, useless instruction? Or enabling more aggressive optimisations by the compiler based on immutability assumptions?
– iago-lito
Feb 27 at 19:22
1
@iago-lito Honestly, I'm not sure, but my uneducated guess is that is does not change anything.
– French Boiethios
Feb 27 at 19:47
1
@iago-lito Right now it actually does! However this is considered a bug and is likely to be fixed at some point.
– mcarton
Feb 27 at 20:13
|
show 1 more comment
It makes fields immutable again.
fields was previously defined as mutable (let mut fields = …;), to be used with sort_by_key which sorts in-place and requires the target to be mutable. The author has chosen here to explicitly prevent further mutability.
"Downgrading" a mutable binding to immutable is quite common in Rust.
Another common way to do this is to use a block expression:
let fields = {
let mut fields = …;
fields.sort_by_key(…);
fields
};
It makes fields immutable again.
fields was previously defined as mutable (let mut fields = …;), to be used with sort_by_key which sorts in-place and requires the target to be mutable. The author has chosen here to explicitly prevent further mutability.
"Downgrading" a mutable binding to immutable is quite common in Rust.
Another common way to do this is to use a block expression:
let fields = {
let mut fields = …;
fields.sort_by_key(…);
fields
};
edited Feb 8 at 15:32
answered Feb 8 at 15:19
mcartonmcarton
7,63322738
7,63322738
34
Or "upgrading", depending upon your perspective.
– Synesso
Feb 9 at 3:06
6
IMO your another way to write that is the way to go: the mutable variable is scoped the time we need to use it, and then it is moved. It is better semantically.
– French Boiethios
Feb 13 at 8:48
@DarthBoiethios Does one or the other changes anything to compiled code? Like adding an additional, useless instruction? Or enabling more aggressive optimisations by the compiler based on immutability assumptions?
– iago-lito
Feb 27 at 19:22
1
@iago-lito Honestly, I'm not sure, but my uneducated guess is that is does not change anything.
– French Boiethios
Feb 27 at 19:47
1
@iago-lito Right now it actually does! However this is considered a bug and is likely to be fixed at some point.
– mcarton
Feb 27 at 20:13
|
show 1 more comment
34
Or "upgrading", depending upon your perspective.
– Synesso
Feb 9 at 3:06
6
IMO your another way to write that is the way to go: the mutable variable is scoped the time we need to use it, and then it is moved. It is better semantically.
– French Boiethios
Feb 13 at 8:48
@DarthBoiethios Does one or the other changes anything to compiled code? Like adding an additional, useless instruction? Or enabling more aggressive optimisations by the compiler based on immutability assumptions?
– iago-lito
Feb 27 at 19:22
1
@iago-lito Honestly, I'm not sure, but my uneducated guess is that is does not change anything.
– French Boiethios
Feb 27 at 19:47
1
@iago-lito Right now it actually does! However this is considered a bug and is likely to be fixed at some point.
– mcarton
Feb 27 at 20:13
34
34
Or "upgrading", depending upon your perspective.
– Synesso
Feb 9 at 3:06
Or "upgrading", depending upon your perspective.
– Synesso
Feb 9 at 3:06
6
6
IMO your another way to write that is the way to go: the mutable variable is scoped the time we need to use it, and then it is moved. It is better semantically.
– French Boiethios
Feb 13 at 8:48
IMO your another way to write that is the way to go: the mutable variable is scoped the time we need to use it, and then it is moved. It is better semantically.
– French Boiethios
Feb 13 at 8:48
@DarthBoiethios Does one or the other changes anything to compiled code? Like adding an additional, useless instruction? Or enabling more aggressive optimisations by the compiler based on immutability assumptions?
– iago-lito
Feb 27 at 19:22
@DarthBoiethios Does one or the other changes anything to compiled code? Like adding an additional, useless instruction? Or enabling more aggressive optimisations by the compiler based on immutability assumptions?
– iago-lito
Feb 27 at 19:22
1
1
@iago-lito Honestly, I'm not sure, but my uneducated guess is that is does not change anything.
– French Boiethios
Feb 27 at 19:47
@iago-lito Honestly, I'm not sure, but my uneducated guess is that is does not change anything.
– French Boiethios
Feb 27 at 19:47
1
1
@iago-lito Right now it actually does! However this is considered a bug and is likely to be fixed at some point.
– mcarton
Feb 27 at 20:13
@iago-lito Right now it actually does! However this is considered a bug and is likely to be fixed at some point.
– mcarton
Feb 27 at 20:13
|
show 1 more comment
The statement let var = var; makes var immutable and bound to its current value. fields was declared as mut earlier.
add a comment |
The statement let var = var; makes var immutable and bound to its current value. fields was declared as mut earlier.
add a comment |
The statement let var = var; makes var immutable and bound to its current value. fields was declared as mut earlier.
The statement let var = var; makes var immutable and bound to its current value. fields was declared as mut earlier.
answered Feb 8 at 15:18
Govind ParmarGovind Parmar
13k53764
13k53764
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54595345%2fwhat-does-let-x-x-do-in-rust%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown