Dtyjlui

I have real trouble getting an if statement to work properly....
here is a link to a zip file with all code needed: https://www.dropbox.com/s/ojsj33oe9ac4g09/latex-rechnung.zip?dl=0

My code:

documentclass[a4paper]{scrlttr2}    

usepackage[top=2cm, bottom=2cm, left=2cm, right=2cm]{geometry}

usepackage{graphicx}

usepackage{lmodern}

usepackage[utf8]{inputenc}

usepackage[T1]{fontenc}

usepackage[ngerman]{babel}

usepackage{color}

usepackage[hidelinks]{hyperref}

usepackage{lipsum}

usepackage{xifthen}



usepackage[german]{invoice}



%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

makeatletter

defUnitDay{Preis/Tag}% <========================================



newcommand{FeeDay@Title}{% <==========================================

    \

    noindenttextbf{Activity}&&UnitDay&Count&Amount (BC)\

    hline%

}%



newcommand{FeeDay}[3]{% Yields state 3, Print Fee Item <==============

    %

    % #1 Contents

    % #2 Fee per Day

    % #3 Unit Count

    %

    ifcaseFlag % 0: Invoice not started yet

        error@message{MissingOpening}%

        %

    %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

    or % 1: Start invoice

        %

        error@message{MissingProject}%

        %

    %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

    or % 2: Start project, print title

        %

        FeeDay@Title%

        Fee@Line{#1}{#2}{#3}%

        %

    %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

    or % 3: Print remuneration item

        %

        Fee@Line{#1}{#2}{#3}%

        %

    %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

    or % 4: Print subtotal remuneration

        %

        warning@message{FeeSTExists}%

        %

    %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

    or % 5: Expense item

        %

        error@message{FeeBeforeExpense}%

        %

    %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

    or % 6: Print subtotal expenses

        %

        error@message{FeeBeforeExpense}%

        %

    %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

    or % 7: Print subtotal project

        %

        error@message{ProjectCompletedNoFee}%

        %

    %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

    or % 8: Print total, close invoice

        %

        error@message{InvoiceCompletedNoFee}%

        %

        %

    else error@message{InternalError}%

    fi%

}%

makeatother





renewcommand{familydefault}{sfdefault}



% include meta data

include{_data} % <============== delete in this file the following data!

% ################## invoice DATA ##################

newcommand{invoiceDate}{today} % Datum der rechnungsstellung

newcommand{invoiceReference}{2019_02_04_1} % Rechnungsnummer (z.B. 20150122-4) YYYYMMDD-1

newcommand{invoiceSalutation}{} % die Anrede

newcommand{invoiceText}{Folgende Positionen werden in Rechnung gestellt:} % Rechnungstext

newcommand{invoiceEnclosures}{} % encl{} einfügen

newcommand{invoiceClosing}{Mit freundlichen Grüßen}

% ################## invoice DATA ##################





% ##################Job DATA ####################

def performaceStart {14.01.2019}

def performaceEnd {01.02.2019}

% ##################Job DATA ####################





% ################## Customer DATA ##################

newcommand{customerCompany}{Firma ABC} %ggf. Firma

newcommand{customerName}{Mustermann} % Name

newcommand{customerStreet}{Straße 123} % Straße

newcommand{customerZIP}{12345} % Postleitzahl

newcommand{customerCity}{Musterstadt} % Ort

newcommand{customerNumber}{1000} % Kundennummer <==================

% ################## Customer DATA ##################



setkomavar{fromname}{senderName}

setkomavar{fromaddress}{senderStreet \ senderZIP  senderCity}

setkomavar{place}{senderCity}

setkomavar{date}{invoiceDate}

setkomavar{fromphone}{senderTelephone}

setkomavar{frommobilephone}{senderMobilephone}

setkomavar{fromemail}{href{mailto:senderEmail}{nolinkurl{senderEmail}}}

setkomavar{subject}{Rechnung}



def invoicenr{Rechnungsnummer: }% <========================================

def customernr{Kundennummer: }%

def performanceDuration{Leistungszeitraum: }



setkomavar{location}{vspace*{-1.99cm}

      \[baselineskip] \[baselineskip]

      flushrightsmall invoicenr invoiceReference\[5pt]

      customernr\

      customerNumber\[5pt]

      performanceDuration\



      newcommand{downow}{

    if performanceEnd == {}

        performaceStart{} -- performaceEnd

    else

        performanceStart

      }

    %      performaceStart{} -- performaceEnd

    }





setkomavar{firsthead}{hfill

   parbox[t][headheight][t]{7.3cm}

   {% 

   footnotesize

   raggedright

   flushright

   color[gray]{.3}%               

   }%

}





begin{document}

    begin{letter}{customerCompany \ customerName \ 

    customerStreet \ customerZIP  customerCity}vspace*{-3.5cm}





            opening{invoiceSalutation}

            invoiceText

            begin{invoice}{Euro}{0}



ProjectTitle{Tagesleistungen} % 

FeeDay{Freelancing}    {300}       {1}



%ProjectTitle{Projekttitel} % 

%Fee{Überstunden}          {37.5}  {4}







% Auslagen

%EBC{Softwarenutzung} {150.00} 

%EBCi{Hotel, 12 Nächte} {2400.00}

%STExpenses



% Rabatt

Discount{Rabatt} {0} % 

            end{invoice}

    ps Bitte zahlen Sie den Gesamtbetrag unter Angabe der Rechnungsnummer auf das aufgeführte Konto.

    ps Kleinunternehmerregelung:\

    Im ausgewiesenen Betrag ist gemäß § 19 UStG keine Umsatzsteuer 

    enthalten.



    closing{invoiceClosing}

    invoiceEnclosures

    vspace*{3.9cm}

    footnotesize ps textbf{Bankverbindung:}hspace{6mm}accountBankName, accountIBAN, accountBIC

    footnotesize ps textbf{Steuernummer:}hspace{8mm}taxID







    end{letter}

end{document}  

I would like to have an if statement that checks if performaceEnd is undefined or empty. If it is empty, under performanceDuration it shall only say performanceStart, if performanceEnd is defined it shall say performanceStart{} -- performanceEnd

Ho do I do that?

The correct way to write your test is

ifxperformanceEndundefined

  performanceStart

elseifxperformanceEndempty

  performanceStart

else

  performanceStart{} -- performanceEnd

fifi

You can also declare a boolean ifperformanceEnd by

newififperformanceEnd

anywhere in the preamble and check performanceEnd with

performanceEndfalse

ifxperformanceEndundefinedelse

  ifxperformanceEndemptyelse

    performanceEndtrue

fifi

then you can write

ifperformanceEnd

  performanceStart{} -- performanceEnd

else

  performanceStart

fi

or even

performanceStartifperformanceEnd{} -- performanceEndfi

Okay, here we go: as already pointed out by @eric-domenjoud you can use ifx to build the variations of text you need. BTW think about adding an "seit " to make clear that the performance time is not over.

I corrected in the following code the wrong written variables performaceStart and performaceEnd to the correct one performanceStart and performanceEnd in the complete following code.

As we did in your last question we once again have to change the code for command location like:

setkomavar{location}{%

      \[baselineskip] \[baselineskip]

      flushrightsmall invoicenr invoiceReference\[5pt]

      customernr\

      customerNumber\[5pt]

      performanceDuration\ 

ifxperformanceEndundefined % <=======================================

  performanceStart

elseifxperformanceEndempty

  performanceStart

else

  performanceStart{} -- performanceEnd

fifi % <==============================================================

    }

Then we get with the following code (you need to use all files in the question linked zip file to be able to compile it!)

 documentclass[a4paper]{scrlttr2}



usepackage[top=2cm, bottom=1cm, left=2cm, right=2cm]{geometry}

usepackage{graphicx}

usepackage{lmodern}

usepackage[utf8]{inputenc}

usepackage[T1]{fontenc}

usepackage[ngerman]{babel}

usepackage{color}

usepackage[hidelinks]{hyperref}

%usepackage {ifthen}



usepackage[german]{invoice}



%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

makeatletter

defUnitDay{Preis/Tag}% <========================================



newcommand{FeeDay@Title}{% <==========================================

    \

    noindenttextbf{Activity}&&UnitDay&Count&Amount (BC)\

    hline%

}%



newcommand{FeeDay}[3]{% Yields state 3, Print Fee Item <==============

    %

    % #1 Contents

    % #2 Fee per Day

    % #3 Unit Count

    %

    ifcaseFlag % 0: Invoice not started yet

        error@message{MissingOpening}%

        %

    %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

    or % 1: Start invoice

        %

        error@message{MissingProject}%

        %

    %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

    or % 2: Start project, print title

        %

        FeeDay@Title%

        Fee@Line{#1}{#2}{#3}%

        %

    %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

    or % 3: Print remuneration item

        %

        Fee@Line{#1}{#2}{#3}%

        %

    %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

    or % 4: Print subtotal remuneration

        %

        warning@message{FeeSTExists}%

        %

    %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

    or % 5: Expense item

        %

        error@message{FeeBeforeExpense}%

        %

    %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

    or % 6: Print subtotal expenses

        %

        error@message{FeeBeforeExpense}%

        %

    %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

    or % 7: Print subtotal project

        %

        error@message{ProjectCompletedNoFee}%

        %

    %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

    or % 8: Print total, close invoice

        %

        error@message{InvoiceCompletedNoFee}%

        %

        %

    else error@message{InternalError}%

    fi%

}%

makeatother





renewcommand{familydefault}{sfdefault}



% include meta data

include{_data} % <============== delete in this file the following data!

% ################## invoice DATA ##################

newcommand{invoiceDate}{today} % Datum der rechnungsstellung

newcommand{invoiceReference}{2019_01_01_1} % Rechnungsnummer (z.B. 20150122-4) YYYYMMDD-1

newcommand{invoiceSalutation}{Sehr geehrte Damen und Herren,} % die Anrede

newcommand{invoiceText}{Folgende Positionen werden in Rechnung gestellt:} % Rechnungstext

newcommand{invoiceEnclosures}{} % encl{} einfügen

newcommand{invoiceClosing}{Mit freundlichen Grüßen}

% ################## invoice DATA ##################





% ##################Job DATA ####################

def performanceStart {01.01.2019}

%def performanceEnd {02.01.2019}

% ##################Job DATA ####################





% ################## Customer DATA ##################

newcommand{customerCompany}{Firma ABC} %ggf. Firma

newcommand{customerName}{Max Mustermann} % Name

newcommand{customerStreet}{Musterstraße 10} % Straße

newcommand{customerZIP}{12345} % Postleitzahl

newcommand{customerCity}{Musterort} % Ort

newcommand{customerNumber}{1000} % Kundennummer <==================

% ################## Customer DATA ##################



setkomavar{fromname}{senderName}

setkomavar{fromaddress}{senderStreet \ senderZIP  senderCity}

setkomavar{place}{senderCity}

setkomavar{date}{invoiceDate}

setkomavar{fromphone}{senderTelephone}

setkomavar{frommobilephone}{senderMobilephone}

setkomavar{fromemail}{href{mailto:senderEmail}{nolinkurl{senderEmail}}}

setkomavar{subject}{Rechnung}



def invoicenr{Rechnungsnummer: }% <========================================

def customernr{Kundennummer: }%

def performanceDuration{Leistungszeitraum: }



setkomavar{location}{%

      \[baselineskip] \[baselineskip]

      flushrightsmall invoicenr invoiceReference\[5pt]

      customernr\

      customerNumber\[5pt]

      performanceDuration\ 

ifxperformanceEndundefined % <=======================================

  performanceStart

elseifxperformanceEndempty

  performanceStart

else

  performanceStart{} -- performanceEnd

fifi % <==============================================================

    }





setkomavar{firsthead}{hfill

   parbox[t][headheight][t]{7.3cm}{% 

   footnotesize

   raggedright

   flushright

   color[gray]{.3}%

    begin{tabular}{rl}

         Anschrift & usekomavar{fromname}\

         & senderStreet\

         & senderZIP   senderCity \

         \

         %Telefon  Telefon:  ` senderTelephone \

         Mobil  & usekomavar{frommobilephone} \

         E-Mail  & usekomavar{fromemail} \

        %Webseite & {normalfontttfamily  senderWeb } \

         \

         Steuernummer & taxID \

         \

         Institut & accountBankName \

         IBAN & accountIBAN \

         BIC & accountBIC

    end{tabular}                   

   }%

}





begin{document}

    begin{letter}{customerCompany \ customerName \ 

    customerStreet \ customerZIP  customerCity}





            opening{invoiceSalutation}

            invoiceText

            begin{invoice}{Euro}{0}



ProjectTitle{Tagesleistungen} % 

FeeDay{Freelance Arbeit}   {10}        {1}



ProjectTitle{Projekttitel} % 

Fee{Überstunden}           {20}    {1}







% Auslagen

%EBC{Hotel, 12 Nächte} {2400.00} % EBCi{Hotel, 12 Nächte} {2400.00}

%STExpenses



% Rabatt

Discount{Rabatt} {0} % 

            end{invoice}

    ps Bitte zahlen Sie den Gesamtbetrag unter Angabe der Rechnungsnummer auf das aufgeführte Konto.

    ps Kleinunternehmerregelung:\

    Im ausgewiesenen Betrag ist gemäß § 19 UStG keine Umsatzsteuer 

    enthalten.



        closing{invoiceClosing}

        invoiceEnclosures







    end{letter}

end{document}

the following result (see that I commented definition of performanceEnd):

If you want to add "seit " as remarked at the beginning of this answer you can use

setkomavar{location}{%

      \[baselineskip] \[baselineskip]

      flushrightsmall invoicenr invoiceReference\[5pt]

      customernr\

      customerNumber\[5pt]

      performanceDuration\ 

ifxperformanceEndundefined % <=======================================

  seit performanceStart

elseifxperformanceEndempty

  seit performanceStart

else

  performanceStart{} -- performanceEnd

fifi % <==============================================================

    }

with the result: